Contributing¶
Contributions are welcome, and they are greatly appreciated! Every little bit helps, and credit will always be given.
Environment setup¶
Nothing easier!
Fork and clone the repository, then:
cd gale-shapley-algorithm
uvx --from taskipy task setup
NOTE: If it fails for some reason, you'll need to install uv manually.
You can install it with:
curl -LsSf https://astral.sh/uv/install.sh | shOn Windows (PowerShell):
powershell -ExecutionPolicy ByPass -c "irm https://astral.sh/uv/install.ps1 | iex"Now you can try running
uvx --from taskipy task setupagain, or simplyuv sync.
You now have the dependencies installed.
Run uvx --from taskipy task --list to see all the available tasks!
Tasks¶
Tasks are defined in pyproject.toml using taskipy.
Run tasks with uvx --from taskipy task <name>. List all available tasks with uvx --from taskipy task --list.
Development¶
- create a new branch:
git switch -c feature-or-bugfix-name - edit the code and/or the documentation
Before committing:
- run
uvx --from taskipy task fixto auto-format and lint-fix the code - run
uvx --from taskipy task cito run all checks (fix any warning) - if you updated the documentation or the project dependencies:
- run
uvx --from taskipy task docs - go to http://localhost:8000 and check that everything looks good
- run
- follow our commit message convention
Creating a pull request:
- (optional) clean up your commits:
git rebase -i main - push your branch:
git push -u origin feature-or-bugfix-name - create the PR:
gh pr create - have it reviewed (or request an AI review with the
/reviewskill) - merge when approved
If you are unsure about how to fix or ignore a warning, just let the continuous integration fail, and we will help you during review.
Don't bother updating the changelog, we will take care of this.
Release workflow (maintainers)¶
After merging PRs, release from main:
git checkout main
git pull
uvx --from taskipy task changelog # auto-update CHANGELOG.md
# review CHANGELOG.md and edit if needed
# update __version__ in src/gale_shapley_algorithm/__init__.py (hatch reads version from here)
git add .
git commit -m "chore: Release version X.Y.Z"
git push
git tag vX.Y.Z
git push --tags
gh release create vX.Y.Z --generate-notes
Commit message convention¶
Commit messages must follow our convention based on the Angular style or the Karma convention:
<type>[(scope)]: Subject
[Body]
Subject and body must be valid Markdown. Subject must have proper casing (uppercase for first letter if it makes sense), but no dot at the end, and no punctuation in general.
Scope and body are optional. Type can be:
build: About packaging, building wheels, etc.chore: About packaging or repo/files management.ci: About Continuous Integration.deps: Dependencies update.docs: About documentation.feat: New feature.fix: Bug fix.perf: About performance.refactor: Changes that are not features or bug fixes.style: A change in code style/format.tests: About tests.
If you write a body, please add trailers at the end (for example issues and PR references, or co-authors), without relying on GitHub's flavored Markdown:
Body.
Issue #10: https://github.com/oedokumaci/gale-shapley-algorithm/issues/10
Related to PR oedokumaci/gale-shapley-algorithm#15: https://github.com/oedokumaci/gale-shapley-algorithm/pull/15
These "trailers" must appear at the end of the body, without any blank lines between them. The trailer title can contain any character except colons :. We expect a full URI for each trailer, not just GitHub autolinks (for example, full GitHub URLs for commits and issues, not the hash or the #issue-number).
We do not enforce a line length on commit messages summary and body, but please avoid very long summaries, and very long lines in the body, unless they are part of code blocks that must not be wrapped.
Pull requests guidelines¶
Link to any related issue in the Pull Request message.
During the review, we recommend using fixups:
# SHA is the SHA of the commit you want to fix
git commit --fixup=SHA
Once all the changes are approved, you can squash your commits:
git rebase -i --autosquash main
And force-push:
git push -f
If this seems all too complicated, you can push or force-push each new commit, and we will squash them ourselves if needed, before merging.